Fix chartjs init for benchmark #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for convenience. I missed initializing the benchmark, but since we always do the same thing everywhere, I suspect I can just do it unconditionally. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
I assume that package.json changes should invalidate the cache for the early copy Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is needed, because we run the patching as part of the postinstall command, and thus, needed it before the full copy. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit too eager and didn't notice that benchmarking was broken for #190, which fixed memory leaks as noticed in #188.
This PR fixes the initialization of ChartJS, doing it now unconditionally when even the relevant code is loaded.
This PR also fixes the Dockerfile so that the patching from #190 also works.
And with that, we see that results are generated now in 22%-40% less time:
https://rebench.dev/ReBenchDB/compare/b0b149a77371ca2e685cf0aab786a32ec26ca958..55c5c5d7ba7d1f6cd4ebbef5febae9bd3bd40539